customizations: add <symbol> to MEI Basic
#1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # customizations/mei-basic.xml
github-actions
bot
added
the
Component: Customizations
ahankinson
reviewed
Jun 20, 2023
musicEnfanthen
changed the title
<symbol> to MEI-Basic<symbol> to MEI Basic
ahankinson
approved these changes
Jun 21, 2023
musicEnfanthen
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the MEI-Basic customization by adding
<symbol>. The element is missing to encode text featuring SMuFL glyphs, such as tempo indications or similar text with music symbols.The PR also removes erroneous references to
att.altSym, which is not available in the customization.