Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: only run prince if command found #1239

Merged
merged 6 commits into from
Jul 7, 2023

Conversation

bwbohl
Copy link
Member

@bwbohl bwbohl commented Jun 21, 2023

This should automatically decide whether to generate the pdf or not, depending on the availability of prince on $PATH.

Please test both in docker-mei and on a local system. Report back on the local system OS, whether Saxon, xerces or prince were available on your $PATH.

@bwbohl bwbohl added this to the MEI 5.0 milestone Jun 21, 2023
@bwbohl bwbohl self-assigned this Jun 21, 2023
@github-actions github-actions bot added the Component: Build changes to build.xml (assigned automatically) label Jun 21, 2023
@bwbohl bwbohl linked an issue Jun 21, 2023 that may be closed by this pull request
@musicEnfanthen musicEnfanthen changed the title 1201 build only run prince if command found build: only run prince if command found Jun 21, 2023
@musicEnfanthen
Copy link
Member

@bwbohl This PR is missing the full section of the old PR where the prince-available command was introduced, so at the moment it is never initiated at all. Also, what is the env variable used for? Is it never called?

https://github.com/music-encoding/music-encoding/pull/1221/files#diff-766797f233c18114f9499750cf1ffbf3829aeea50283850619c01bd173132021R137-R148

build.xml Outdated Show resolved Hide resolved
@bwbohl
Copy link
Member Author

bwbohl commented Jul 4, 2023

@musicEnfanthen reintroduced missing section, please have a second look ;-)

Copy link
Member

@musicEnfanthen musicEnfanthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and with docker, thanks.

@musicEnfanthen musicEnfanthen merged commit 3042ae1 into develop Jul 7, 2023
1 check passed
@musicEnfanthen musicEnfanthen deleted the 1201-build-only-run-prince-if-command-found branch July 7, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build changes to build.xml (assigned automatically)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

build: only run prince if command found
3 participants