Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-actions: fix hard-coded PDF name in deploy action, part 2 #1241

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

musicEnfanthen
Copy link
Member

@musicEnfanthen musicEnfanthen commented Jun 21, 2023

This PR is a follow-up to #1223 because a reference to the hard-coded PDF file name was overlooked. It provides another step for fixing #1125.

However, this reference here cannot be fixed by a wildcard glob since globs do not work with linux copy command cp. For that reason, the copy command gets piped through a find that will lookup the wildcard file name and hand it over to the cp process.

Finding and copying worked fine locally, we have to check how it works in the CI environment.

@github-actions github-actions bot added the Component: Workflows changes to GitHub Actions workflows (assigned automatically) label Jun 21, 2023
@bwbohl bwbohl added this to the MEI 5.0 milestone Jun 27, 2023
@bwbohl bwbohl requested a review from rettinghaus June 29, 2023 20:44
@bwbohl bwbohl self-assigned this Jun 29, 2023
@bwbohl bwbohl merged commit e711c39 into music-encoding:develop Jul 4, 2023
2 checks passed
@musicEnfanthen musicEnfanthen deleted the fix-deploy-action branch July 5, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Workflows changes to GitHub Actions workflows (assigned automatically)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants