customizations: adjustment to MEI Basic #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove attribute classes not relevant in basic
* Same as for breath, remove attribute classes not used in basic
github-actions
bot
added
the
Component: Customizations
musicEnfanthen
changed the title
rettinghaus
approved these changes
Jun 22, 2023
ahankinson
approved these changes
Jun 23, 2023
musicEnfanthen
approved these changes
Jun 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR does two things
Unify visual attribute classes
There was different discrepancies in the visual attribute classes (e.g., att.typography available in some cases but not other, and same for att.visualOffset`). The PR unifies them.
Add att.extender
This attribute classes was deleted and was missing for encoding dynamic or tempo extenders, something that should definitely be possible in MEI-Basic