schema: add support to encode the level where a proportion is applied #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new attribute defines the level at which a proportion applies.
This attribute defines the level at which a proportions applies.
github-actions
bot
added
Component: Guidelines & Documentation
annplaksin
approved these changes
Jul 28, 2023
|
Btw, I blame @lpugin for making me try to push this for MEI 5.0 😜 |
lpugin
previously approved these changes
Jul 28, 2023
musicEnfanthen
changed the title
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
lpugin
reviewed
Jul 28, 2023
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Laurent Pugin <lxpugin@gmail.com>
lpugin
approved these changes
Jul 28, 2023
musicEnfanthen
approved these changes
Jul 28, 2023
|
Thank you all! Thanks @pe-ro, @lpugin, @musicEnfanthen, @annplaksin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request we are:
@levelwhich indicates the level at which a proportion is applied.<mensur>in sesquialtera proportion, where the mensuration is also changed as an effect of the use of this proportion).The pull request generates valid schemas for Mei-all and Mei-mensural:
schemas to test.zip
And the use of the
@levelattribute is valid when using these both schemas, as can be tested when using the following file (provided by @annplaksin) and substituting the online schema by any of the two attached above.sesquialtera_level.mei.zip
The discussion about this attribute can be seen here: music-encoding/mensural-ig#16