Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema: reduce version number #1300

Merged
merged 3 commits into from
Aug 28, 2023
Merged

schema: reduce version number #1300

merged 3 commits into from
Aug 28, 2023

Conversation

musicEnfanthen
Copy link
Member

This PR is a first step towards v5.0 as it reduces the current version number to two levels (5.0-dev).

Fixes #1174

@github-actions github-actions bot added Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) Component: Core Schema changes to source/modules/* (assigned automatically) Component: Customizations changes to customizations/**/* (assigned automatically) labels Aug 1, 2023
@musicEnfanthen musicEnfanthen changed the base branch from develop to release/v5.0 August 1, 2023 10:37
@musicEnfanthen
Copy link
Member Author

Do we need to change the version numbers for the files in tests as well?

@musicEnfanthen musicEnfanthen added this to the MEI 5.0 milestone Aug 1, 2023
@rettinghaus
Copy link
Member

I think the tests need to be updated accordingly. (There is still a version 3.0.0, so I wonder if we even do testing …)

@bwbohl
Copy link
Member

bwbohl commented Aug 1, 2023

testing was stopped quite a while ago but it still sits there to keep nagging that we should do test ;-)

@bwbohl
Copy link
Member

bwbohl commented Aug 1, 2023

updating them of, course would be good

@bwbohl
Copy link
Member

bwbohl commented Aug 1, 2023

Why not leave away the -dev part everywhere on this branch?

@musicEnfanthen
Copy link
Member Author

@bwbohl I think it is better to go in two steps. First consolidate all the version numbers to 5.0-dev (which allows testing properly since it points to dev version), and then change to 5.0 for the release.

@bwbohl bwbohl merged commit e4ff2e2 into music-encoding:release/v5.0 Aug 28, 2023
2 checks passed
@musicEnfanthen musicEnfanthen deleted the reduce-version-number branch September 4, 2023 20:28
@musicEnfanthen musicEnfanthen mentioned this pull request Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbohl bwbohl bwbohl approved these changes

Assignees
No one assigned
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Component: Customizations changes to customizations/**/* (assigned automatically) Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically)
Projects
ODD meetings
Status: ✅ Done
Milestone
MEI 5.0
Development

Successfully merging this pull request may close these issues.

build: reduce version number to 2 levels
3 participants
@musicEnfanthen @rettinghaus @bwbohl