Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customizations: fix missing @n in verse in MEI Basic #1309

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

lpugin
Copy link
Member

@lpugin lpugin commented Aug 13, 2023

One or more verse is allowed, but no @n. It is semantically problematic and since this is a critical bug in MEI Basic I am making a PR to the release candidate.

@github-actions github-actions bot added the Component: Customizations changes to customizations/**/* (assigned automatically) label Aug 13, 2023
Copy link
Member

@rettinghaus rettinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally sure we need label in Basic, but apart from that it looks good. Thank you.

@musicEnfanthen musicEnfanthen changed the title Fix customization: verse missing @n in MEI Basic customizations: fix missing @n in verse in MEI Basic Aug 13, 2023
@bwbohl bwbohl added this to the MEI 5.0 milestone Aug 23, 2023
@bwbohl bwbohl merged commit 45e3ea4 into music-encoding:release/v5.0 Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customizations changes to customizations/**/* (assigned automatically)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants