gh-actions: fix release workflow #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Workflows
ahankinson
reviewed
Sep 1, 2023
.github/workflows/deploy.yml
Outdated
| - name: Validate TARGET_DIR | ||
| run: echo "TARGET_DIR=$TARGET_DIR" | ||
|
|
||
| ### Exit if ref is not develop branch or release tag |
There was a problem hiding this comment.
This could probably be moved up the chain, since it doesn't require anything else to run (I don't think?). There's no point getting this far if we're just going to exit...
There was a problem hiding this comment.
We wanted to run the build and artifact upload before exiting (on each branch that triggers the workflow). But you are right, we could probably exit before setting the target_dir variable.
|
You're a star, @musicEnfanthen ! GH Actions are not fun to write. |
Merged
|
@ahankinson If you are OK with the latest changes, you can merge this PR. It goes to the release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the failing release workflow. It imrpoves and simplifies the exit and if conditions, and adds some validation steps that will make it easier to debug failing workflows in the future.