Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mensur and propert from scoreDef/staffDef #541

Merged
merged 9 commits into from
May 29, 2020

Conversation

rettinghaus
Copy link
Member

This PR removes mensur and proport (with respective attributes) from scoreDef/staffDef as discussed and approved at the Mensural Interest Group's meeting at College Park.

Two main reasons:
<meter> and the respective short hand notation is used on scoreDef, because meter changes happen between two measures in measured music. As mensural music is un-measured, there is basically no need to keep it on scoreDef.
When the mensur changes however, the new mensur has to be encoded in the stream (i.e. the layer). So the traditional approach would be something like this:

<staffDef mensur.sign=„O" mensur.dot="true" mensur.slash="1" mensur.color="red" />
<section>
   <staff n="1">
       <layer>
	    <note />
	    <note />
	    <note />
	    <mensur loc="3" sign="C" />
	    <note />
	    <note />
	    <note />
	</layer>
   </staff>
</section>

But basically there is no point for the encoding of the first mensuration sign to be distinct from the following ones.
The same encoding would make more sense (and raise consistency) this way:

<section>
   <staff n="1">
       <layer>
	    <mensur sign="O" dot="true" slash="1" color="red" />
	    <note />
	    <note />
	    <note />
	    <mensur loc="3" sign="C" />
	    <note />
	    <note />
	    <note />
	</layer>
   </staff>
</section>

Additionally this decreases the "zoo of attributes" on the def elements.

@giulianodibacco
Copy link

This is very useful and very logical. We had almost no discussion at the IG meeting because it looked immediately as the best option to have where it happens in the stream. It would be good to include in the guidelines two (real) examples: 1) two mensuration signs in the stream (a change of mensuration) of the kind @rettinghaus exemplified. And 2) an example with no mensuration signs (i.e. where the mensura is given by the context). I think that this pair of examples will reinforce the concept. -- But then I have a big question here: are then mensuration signs part of the logical, or visual domain? The question arose some time ago because there are cases where we have more than one sign meaning the same mensuration. See the discussion in #537

Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been properly reviewed in the context of #634

@kepper kepper merged commit 03e9478 into music-encoding:develop May 29, 2020
@kepper
Copy link
Member

kepper commented May 29, 2020

thanks @martha-thomae for your work on this!!!

@martha-thomae
Copy link
Contributor

Thanks to you for all the help and patience with a novice in ODD-related stuff.

@rettinghaus rettinghaus deleted the develop-mensural branch May 30, 2020 18:22
@bwbohl
Copy link
Member

bwbohl commented Jun 7, 2020

am I right to assume tat this is one of the PRs breaking backward compatibility, ergo making the new MEI release 5.0?

@bwbohl bwbohl added this to the MEI 5.0.0 milestone Jun 7, 2020
@martha-thomae
Copy link
Contributor

Yes, you are right. This is supposed to go to MEI version 5.0.

martha-thomae added a commit that referenced this pull request Jun 18, 2020
Revert "Merge pull request #541 from rettinghaus/develop-mensural"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants