-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first beta of MEI Basic #584
Conversation
customizations/mei-basic.xml
Outdated
</constraintSpec> | ||
|
||
<moduleRef key="MEI"/> | ||
<moduleRef key="MEI.cmn" except="beamSpan bend bracketSpan meterSig meterSigGrp mSpace oLayer ossia oStaff tupletSpan"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about meterSig
being excluded.
The spreadsheet isn’t addressing everything, but we made a statement there about meterSig to be excluded. I think the idea was to encourage people to use scoreDef between measures instead. Basic should exclude meters changing in the middle of a measure (no clue how this would work anyway…)
|
Makes sense. Is |
If I remember correctly (in need of a power outlet to verify…) the argument to keep keySig was that keys may actually change in the middle of a measure. However, we should make sure that it’s not used inside scoreDef…
|
I would like to see us address #582 first before merging this PR. MEI Basic shouldn't land as part of 4.0.1. |
Release 4.0.1
please test thoroughly
We now have a first beta of MEI Basic. It hasn't been tested to great detail yet, though, so please have a look. I'm particularly curious to hear from @rettinghaus and @lpugin if it has everything that's needed for rendering with Meiler and Verovio, respectively. |
This is the first Release Candidate for MEI Basic (formerly known as MEI Go).
Dear @music-encoding/core-contributors, dear all, I finally managed to get around with the draft of MEI Basic, as we've discussed in the past. Please have a look and see, I surely missed some aspects. It is pretty restrictive, but is build to allow integration of additional features in the future without causing many disruptions -> very often, we picked elements, but disallowed all advanced attributes on them for the time being. For the |
btw., could someone more familiar with Travis look into the build failures? They don't seem to originate from problems in the repo, but in the Travis setup. @ahankinson, are you able to help out? |
I think the Travis issue is the one I fixed on the pull request for the mensural module (see 4fbb831). I was the first one who got the building error, so I added this fix in the PR so that, when accepted, it would build fine for all. (I don't know Travis, this was with the help of someone from my Lab that does. It built ok after that commit.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stem.dir
missing on <chord>
@fontname
missing on <rend>
@accid
is allowed on <note>
but not @accid.ges
@vgrp
missing on <dynam>
(I would still consider basic, but maybe not everybody would agree)
@oloc
and @ploc
on <rest>
(ditto)
cudos to @martha-thomae, #584 (comment)
This resolves the stem.dir issue, re-allows fontname, and takes care of accid (which is supposed to be an element anyway). I did not allow vgrp and oloc, though. Those can be added when there is more substantial demand…
For evaluating it with MNX, we should use the test files provided in their converter https://github.com/w3c/mnxconverter/tree/master/tests |
first beta of MEI Basic
this adds a draft for MEI basic, based on our discussions in Oxford. It's still not complete and needs significant consideration of:
We could continue to develop in this branch, or merge it into develop.