Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first beta of MEI Basic #584

Merged
merged 9 commits into from
Apr 30, 2020
Merged

first beta of MEI Basic #584

merged 9 commits into from
Apr 30, 2020

Conversation

kepper
Copy link
Member

@kepper kepper commented Apr 4, 2019

this adds a draft for MEI basic, based on our discussions in Oxford. It's still not complete and needs significant consideration of:

  • how much metadata should be included
  • make sure controlevents have one method for placement only (but potentially a different for every type)

We could continue to develop in this branch, or merge it into develop.

@kepper kepper requested a review from a team April 4, 2019 11:43
</constraintSpec>

<moduleRef key="MEI"/>
<moduleRef key="MEI.cmn" except="beamSpan bend bracketSpan meterSig meterSigGrp mSpace oLayer ossia oStaff tupletSpan"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about meterSig being excluded.

@kepper
Copy link
Member Author

kepper commented Apr 4, 2019 via email

@lpugin
Copy link
Member

lpugin commented Apr 4, 2019

The spreadsheet isn’t addressing everything, but we made a statement there about meterSig to be excluded. I think the idea was to encourage people to use scoreDef between measures instead. Basic should exclude meters changing in the middle of a measure (no clue how this would work anyway…)

Makes sense. Is keySig excluded as well? It should be

@kepper
Copy link
Member Author

kepper commented Apr 4, 2019 via email

@ahankinson ahankinson requested a review from bwbohl April 5, 2019 09:21
@ahankinson
Copy link
Member

ahankinson commented Apr 5, 2019

I would like to see us address #582 first before merging this PR. MEI Basic shouldn't land as part of 4.0.1.

@ahankinson ahankinson added this to the MEI 4.1.0 milestone Apr 12, 2019
@bwbohl bwbohl self-assigned this Jul 29, 2019
please test thoroughly
@kepper
Copy link
Member Author

kepper commented Oct 26, 2019

We now have a first beta of MEI Basic. It hasn't been tested to great detail yet, though, so please have a look. I'm particularly curious to hear from @rettinghaus and @lpugin if it has everything that's needed for rendering with Meiler and Verovio, respectively.

@kepper kepper changed the title first draft of MEI Basic first beta of MEI Basic Oct 26, 2019
This is the first Release Candidate for MEI Basic (formerly known as MEI Go).
@kepper
Copy link
Member Author

kepper commented Apr 27, 2020

Dear @music-encoding/core-contributors, dear all, I finally managed to get around with the draft of MEI Basic, as we've discussed in the past. Please have a look and see, I surely missed some aspects. It is pretty restrictive, but is build to allow integration of additional features in the future without causing many disruptions -> very often, we picked elements, but disallowed all advanced attributes on them for the time being. For the @meiversion-attribute, the allowed value is 4.0.1-rc1+basic. I like the +basic part at the end (which is a possible part in semantic versioning), because it allows us to indicate MEI profiles in the schema. We may even have multiple profile combinations (something like cmn + mensural), and control them through a regex, instead of a value list as we have right now. However, that'll be a separate issue to discuss… 

@kepper
Copy link
Member Author

kepper commented Apr 27, 2020

btw., could someone more familiar with Travis look into the build failures? They don't seem to originate from problems in the repo, but in the Travis setup. @ahankinson, are you able to help out?

@martha-thomae
Copy link
Contributor

martha-thomae commented Apr 27, 2020

btw., could someone more familiar with Travis look into the build failures? They don't seem to originate from problems in the repo, but in the Travis setup. @ahankinson, are you able to help out?

I think the Travis issue is the one I fixed on the pull request for the mensural module (see 4fbb831). I was the first one who got the building error, so I added this fix in the PR so that, when accepted, it would build fine for all. (I don't know Travis, this was with the help of someone from my Lab that does. It built ok after that commit.)

Copy link
Member

@lpugin lpugin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stem.dir missing on <chord>
@fontname missing on <rend>
@accid is allowed on <note> but not @accid.ges
@vgrp missing on <dynam> (I would still consider basic, but maybe not everybody would agree)
@oloc and @ploc on <rest> (ditto)

@lpugin lpugin self-requested a review April 28, 2020 16:31
kepper added a commit that referenced this pull request Apr 29, 2020
This resolves the stem.dir issue, re-allows fontname, and takes care of accid (which is supposed to be an element anyway). I did not allow vgrp and oloc, though. Those can be added when there is more substantial demand…
@bwbohl bwbohl merged commit bbd12c0 into develop Apr 30, 2020
@lpugin
Copy link
Member

lpugin commented May 1, 2020

For evaluating it with MNX, we should use the test files provided in their converter https://github.com/w3c/mnxconverter/tree/master/tests
(We could easily have an importer in Verovio for them. To test with MEI basic we should add an option to set a specific schema in the MEI output, but this is straighforward)

@bwbohl bwbohl deleted the basic branch May 2, 2022 23:20
rettinghaus pushed a commit to rettinghaus/music-encoding that referenced this pull request Mar 9, 2023
rettinghaus pushed a commit to rettinghaus/music-encoding that referenced this pull request Mar 9, 2023
@bwbohl bwbohl modified the milestones: MEI 4.1.0, MEI 5.0.0 May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants