Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow color on key signatures #611

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

rettinghaus
Copy link
Member

This PR makes att.keyAccid.vis and att.keySig.vis member of att.color.

@rettinghaus
Copy link
Member Author

@bwbohl could you check and approve?

@ahankinson ahankinson self-requested a review October 9, 2019 22:13
@ahankinson
Copy link
Member

ahankinson commented Oct 9, 2019

Is there an issue or some other explanation of the reason for this change available?

@rettinghaus
Copy link
Member Author

I didn't open another issue for this, as I thought it would be self-explanatory.
Refers to issues #346 #517 #518 #524

@ahankinson
Copy link
Member

Great, that's all I needed -- just some reference so that we have a record of why the change is being requested.

@ahankinson ahankinson merged commit 77c9a59 into music-encoding:develop Oct 10, 2019
@rettinghaus
Copy link
Member Author

Thanks!

@rettinghaus rettinghaus deleted the develop-color branch October 10, 2019 09:18
rettinghaus pushed a commit to rettinghaus/music-encoding that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants