fix midi value issue #640
Merged
fix midi value issue #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kepper
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Basically, the change is correct and fine. I wonder, though, why / if we need to give percentages at all, as MIDI itself doesn't use percentages. Yes, they're easier to read, but will people use this beyond directly interfacing with MIDI files? We may want to revise this independent of the current PR…
|
Yes, there is not great need for encoding MIDI volumes as percentages since the volume values in MIDI can only be 0 to 127 and will never change (at least for the MIDI 1.0 standard). So the only function of percentages would be to make it easier for people to read. |
rettinghaus
pushed a commit
to rettinghaus/music-encoding
that referenced
this pull request
Mar 9, 2023
fix midi value issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #638