Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tempo text with extension lines #646

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Support tempo text with extension lines #646

merged 1 commit into from
Oct 16, 2020

Conversation

th-we
Copy link
Member

@th-we th-we commented Feb 20, 2020

Analogously to <dynam> with extension lines, supports this:

grafik

(Gould, p. 184)

@rettinghaus
Copy link
Member

@th-we please fix the title of this PR

@th-we th-we changed the title Support dynamics with extension lines Support tempo text with extension lines Feb 22, 2020
@th-we
Copy link
Member Author

th-we commented Feb 22, 2020

@rettinghaus That's a good idea, of course.

@rettinghaus
Copy link
Member

a more common example maybe is this:
lily-bca5e23b

@th-we
Copy link
Member Author

th-we commented Jun 20, 2020

When I created this PR, the checks failed with this error

The command "curl -O http://central.maven.org/maven2/net/sf/saxon/Saxon-HE/9.8.0-5/Saxon-HE-9.8.0-5.jar" failed and exited with 6 during .

Any way to re-trigger the checks?

kepper
kepper approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is correct, there are examples illustrating the need – all perfect ;-) We just should consider to add such examples to the Guidelines…

@kepper kepper added the Status: Ready To Merge indicates that a pull request is ready for merging label Oct 16, 2020
@kepper kepper merged commit 6510435 into music-encoding:develop Oct 16, 2020
@musicEnfanthen musicEnfanthen removed the Status: Ready To Merge indicates that a pull request is ready for merging label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kepper kepper kepper approved these changes

@rettinghaus rettinghaus rettinghaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@th-we @rettinghaus @kepper @musicEnfanthen