Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mensural source #670

Merged
merged 5 commits into from
May 29, 2020
Merged

Mensural source #670

merged 5 commits into from
May 29, 2020

Conversation

martha-thomae
Copy link
Contributor

This PR replaces #634. It includes the exact same changes, but the changes are done in the source files (rather than in the customization file as in #634).

Change in the general description (dur refers to the note symbol, not to the duration of the note) and change in the description of the 'brevis', 'semiminima', 'fusa', and 'semifusa'.
Given that mensural notes can have two stems (with different directions and their own forms and flags), the mensural-ig approved the idea of introducing the 'stem' element as a child of the 'note' element. The changes here allow for the use of this 'stem' element and for its attributes: pos, length, form, dir, flag.pos, flag.form, x, and y.
The mensural-ig also approved the introduction of the 'stem.form' attribute to be used within the note element (the other attributes corresponding to position, length, direction, and x and y coordinates are already included in the current specification of MEI).
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been properly reviewed in #634 already

@kepper kepper merged commit d327c51 into music-encoding:develop May 29, 2020
@martha-thomae martha-thomae deleted the mensural_source branch July 27, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants