Remove explicit mei_ prefix so elements get listed in HTML documentation #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettinghaus
approved these changes
Sep 22, 2020
kepper
approved these changes
Oct 15, 2020
kepper
added
the
Status: Ready To Merge
musicEnfanthen
removed
the
Status: Ready To Merge
rettinghaus
pushed a commit
to rettinghaus/music-encoding
that referenced
this pull request
Mar 9, 2023
Remove explicit mei_ prefix so elements get listed in HTML documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that
<symbol>is allowed in both<mapping>and<symbolDef>, but they are not listed in the HTML documentation. I assume this is because of themei_prefix that was added explicitly here, but the HTML generation can't handle it. Same thing happens for<marker>inside<midi>As far as I see, it makes no difference to not add the prefix explicitly. I assume it was originally added because of SVG elements with the same names (
<symbol>and<marker>). However, I don't really see how that could cause a conflict because the prefixsvg_is used for those.