Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fermata attribute for mensural notes #723

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Add fermata attribute for mensural notes #723

merged 3 commits into from
Oct 29, 2020

Conversation

martha-thomae
Copy link
Contributor

The fermata attribute (found in the att.fermataPresent class) is only available for notes in CMN.

In this PR, I add the missing class att.note.anl.mensural (the logical, gestural, and visual corresponding classes already exist), and make it a member of att.fermataPresent, similar to how att.note.anl.cmn is a member of att.fermataPresent. Then include the newly introduced att.note.anl.mensural class in the classes of att.note.anl.

@craigsapp
Copy link
Member

I do not have a problem with allowing <fermata>, but note that it is often called corona in mensural music. with the link saying:

It is similar to the fermata in modern notation.

Perhaps there is no functional difference between them, in which case using fermata as the name for the mensural version is no problem. (I am not aware of any difference at all, at least in the music of Josquin).

Perhaps some mensuralists could comment on if there is any real difference between them?

@craigsapp
Copy link
Member

Jesse Rodin cannot think of any difference between a fermata and a corona, so it should be safe to assume that they are equivalent.

@martha-thomae
Copy link
Contributor Author

Hi @craigsapp! Thank you for checking on this :)

Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me

@kepper kepper added the Status: Ready To Merge indicates that a pull request is ready for merging label Oct 29, 2020
@kepper kepper merged commit d420906 into music-encoding:develop Oct 29, 2020
@musicEnfanthen musicEnfanthen removed the Status: Ready To Merge indicates that a pull request is ready for merging label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants