Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pattern for humdrum recip values #726

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Update pattern for humdrum recip values #726

merged 1 commit into from
Mar 26, 2021

Conversation

rettinghaus
Copy link
Member

See discussion on rism-digital/verovio#1796

@bwbohl bwbohl self-requested a review March 18, 2021 21:21
bwbohl
bwbohl approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@bwbohl bwbohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates the definition of @dur.recip to match the current Humdrum definition (in place for 10 years!!)

@bwbohl bwbohl added this to 2021-03-26: ODD Friday in ODD Meetings Mar 18, 2021
@bwbohl bwbohl added Status: Ready To Merge indicates that a pull request is ready for merging Component: Core Schema changes to source/modules/* (assigned automatically) Type: Bugfix indicates that a fix for a bug has been provided labels Mar 18, 2021
@kepper kepper merged commit a11eba6 into music-encoding:develop Mar 26, 2021
@kepper
Copy link
Member

kepper commented Mar 26, 2021

thanks for the good catch :-)

@rettinghaus rettinghaus deleted the develop-recip branch March 29, 2021 07:25
@musicEnfanthen musicEnfanthen removed the Status: Ready To Merge indicates that a pull request is ready for merging label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbohl bwbohl bwbohl approved these changes

Assignees
No one assigned
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Type: Bugfix indicates that a fix for a bug has been provided
Projects
No open projects
ODD Meetings
  
2021-03-26: ODD Friday
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rettinghaus @kepper @bwbohl @musicEnfanthen