Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pr-labeler.yml #735

Merged
merged 12 commits into from
Jan 19, 2021
Merged

Create pr-labeler.yml #735

merged 12 commits into from
Jan 19, 2021

Conversation

bwbohl
Copy link
Member

@bwbohl bwbohl commented Nov 13, 2020

This is a test implantation of the GHActions Labeler to automatically label pulls requests based on the files they modify. At the moment there is an issue with our labels having »:« in their names as I don't know how to mask them in the .yml.

Currently only set for labels Comoponent Workflows and Component Core Schema

@musicEnfanthen
Copy link
Member

Nice action. :)

Ad masking: Did you try to use quotes around the key? (cf. https://stackoverflow.com/questions/14873227/escaping-colons-in-yaml)

@bwbohl
Copy link
Member Author

bwbohl commented Nov 16, 2020

Nice action. :)

Ad masking: Did you try to use quotes around the key? (cf. https://stackoverflow.com/questions/14873227/escaping-colons-in-yaml)

No actually not… gotta give it a try

@github-actions github-actions bot added the Component: Workflows changes to GitHub Actions workflows (assigned automatically) label Nov 16, 2020
@bwbohl
Copy link
Member Author

bwbohl commented Nov 16, 2020

masking works perfectly thanks @musicEnfanthen!

@musicEnfanthen
Copy link
Member

Perfect

@musicEnfanthen
Copy link
Member

Do you want that one to be merged already, or do you want to add more labels first?

add rule for changes to source/docs/* labeling as "Component: Guidelines & Documentation"
@bwbohl
Copy link
Member Author

bwbohl commented Dec 9, 2020

probably we cann merge it already and add other locations later?

Copy link
Member

@musicEnfanthen musicEnfanthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@musicEnfanthen
Copy link
Member

Unfortunately, you will need another reviewer with write access to get this merged. Maybe @kepper or @lpugin can help?

@lpugin
Copy link
Member

lpugin commented Jan 19, 2021

I am curious to know if this works with PRs coming from external contributors. Do you know if this will work?

@bwbohl bwbohl merged commit 21798e0 into develop Jan 19, 2021
@bwbohl bwbohl deleted the bwbohl-pr-labeler branch March 4, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Workflows changes to GitHub Actions workflows (assigned automatically)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants