Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add turkish AEU accidentals to data.ACCIDENTAL.GESTURAL #772

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

annplaksin
Copy link
Member

This is the sequel PR to #720 :
Since the aeu accidental values cannot be expressed with the already existing values of data.ACCIDENTAL.GESTURAL, it would be very helpful to add them as gestural values too.

I splitted data.ACCIDENTAL.GESTURAL as it has been done for written accidentals in #720 and added the aeu accidentals. To avoid the duplication of data types, I renamed data.ACCIDENTAL.WRITTEN.aeu to data.ACCIDENTAL.aeu.

A corrected version of the aeu accidental value overview has been added as well.

@bwbohl bwbohl added this to 2021-03-26: ODD Friday in ODD Meetings Mar 18, 2021
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't compile to see if the image links work, but other than that seems plausible – thanks for the work on that 👍

@kepper kepper merged commit f58c154 into music-encoding:develop Mar 26, 2021
@kepper
Copy link
Member

kepper commented Mar 26, 2021

thanks for your work on this, @annplaksin 👍

@rettinghaus
Copy link
Member

Sorry for me complaining about this so late, but even if AEU accidentals would have be the same in gestural and visual domain, I don't think we should combine them nto data.ACCIDENTAL.aeu, as this breaks current naming (and basically the current schema). I would prefer to keep data.ACCIDENTAL.WRITTEN.aeu and add data.ACCIDENTAL.GESTURAL.aeu instead.

@annplaksin
Copy link
Member Author

You have either a break of naming or redundancy. I asked @kepper before I made the pull request if this naming is okay. He didn't complain.

@kepper
Copy link
Member

kepper commented Jul 8, 2021

I'm certainly not the the person to decide what is right or wrong here – MEI is a community thing, and we should move forward by consensus whenever possible. I think this is a legitimate question, though, and while I refuse to be any more relevant for the decision than anyone else, I think there are arguments that @annplaksin's implementation is actually consistent with existing MEI.

In CWMN accidentals, we see a certain amount of duplication of visual values: x is two half-tones up, as is ss. For gestural purposes, there's no difference between them, though. This difference legitimates to have two separate data types for the two domains. In the list suggested by @annplaksin, there is no similar duplication of values. Accordingly, we don't need to split this up by domain. I think this is conforming to other situations in MEI. The data.DURATION.cmn data type is used by both data.DURATION (applies to @dur) and data.DURATION.gestural (applies to @dur.ges) – as the values apply to both categories alike.

I think we all agree that MEI is a "grown" model that isn't perfectly consistent across all of its parts. In this particular situation, I think we're safely within the "usual range", though – but this is definitely something to discuss and negotiate…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
ODD Meetings
  
2021-03-26: ODD Friday
Development

Successfully merging this pull request may close these issues.

None yet

3 participants