-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #774
Update README #774
Conversation
with information on new build-setup and local build instructions
@martha-thomae could you please add the documentation of how to build using oXygen XML? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this important documentation!
fix typo Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Added some more comments while going through the file again (please discard anything you think is unnecessary).
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
* add all costomizations * add link to respective customisation files
add links to folder names
Moreover the section on Validation is outdated |
Working on this I get the impression it's a bit long for a README and probably should be split int several files after all content is up to date. What do you thing @musicEnfanthen? |
Thanks a lot, @bwbohl !
Not sure about that. There are much longer READMEs out there, and it's nice to have the most important information/instruction in one place. But of course, splitting things up can improve readability and overall structure (especially when it comes to different, independent build scenarios). E.g. Verovio's README follows such an approach: https://github.com/rism-digital/verovio#building-and-use-instructions-by-environment Maybe it's an idea to stick with the one document for this PR, to have all the phrasings and contents updated and included, and to have another PR then to split things up? |
@musicEnfanthen is this a go to merge or should we wait for @martha-thomae to add oXygen-specific documentation? |
Is it technically possible to include @martha-thomae's additions in the same PR? |
Yes, if she clones https://github.com/music-encoding/music-encoding/tree/local-build-instructions and commits her changes there, they would automatically get part of this PR |
Hi! Thanks for all your work on this @bwbohl, and thanks @musicEnfanthen for your detailed review of this PR. Looks awesome! I will focus on reviewing the building instructions then. I would prefer if you wait for me to include the information for Oxygen, so that everything in issue #763 gets resolved in the same PR. I will make these changes (and evaluate the building instructions @bwbohl provided) closer to the ODD Meeting, though (I have so many deadlines in March). So, if you prefer to merge now, and for me to make the changes later in a new PR, that is fine too. |
thx @martha-thomae for adding and reviewing! |
Thank you all for having a look at this. One section that I noticed that was missing was (maybe) at the very beginning, to point people to URLs where they can find the pre-built schemas. That would help those people who want to develop with MEI, but don't necessarily want to develop MEI itself. |
No problem, @bwbohl! Your documentation was pretty clear so it was easy to review. Thanks for your work! |
Perfect, we will add this. Thanks for taking a look, @ahankinson! |
There's still one TODO that I see here: fixing the section on validation to use current schemata |
thanks to everyone involved! |
with information on new build-setup and local build instructions
closes: #763