Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary comment #780

Merged
merged 1 commit into from
Mar 26, 2021
Merged

remove unnecessary comment #780

merged 1 commit into from
Mar 26, 2021

Conversation

kepper
Copy link
Member

@kepper kepper commented Mar 26, 2021

fixes music-encoding/guidelines#197

the comment in question is too long for one line, and apparently something in the pipeline inserts a line break, which has led to partial re-insertion of the commented code. The result was invalid JS code, which could not be parsed and thus stopped browsers. As the comment is just for debugging, it can safely go away.

fixes music-encoding/guidelines#197

the comment in question is too long for one line, and apparently something in the pipeline inserts a line break, which has led to partial re-insertion of the commented code. The result was invalid JS code, which could not be parsed and thus stopped browsers. As the comment is just for debugging, it can safely go away.
@kepper kepper requested a review from bwbohl March 26, 2021 00:19
@github-actions github-actions bot added the Component: Utils changes to utils/**/* (assigned automatically) label Mar 26, 2021
@kepper kepper added this to 2021-03-26: ODD Friday in ODD Meetings Mar 26, 2021
@bwbohl bwbohl merged commit d157098 into develop Mar 26, 2021
@bwbohl bwbohl deleted the bugfix_197 branch April 7, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Utils changes to utils/**/* (assigned automatically)
Projects
No open projects
ODD Meetings
  
2021-03-26: ODD Friday
Development

Successfully merging this pull request may close these issues.

tabs in dev not working on firefox
2 participants