Update CONTRIBUTING.md #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix capitalisation of: ** "Core Contributors" ** "Technical Team"
musicEnfanthen
requested changes
Oct 28, 2021
capitalize heading Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
fix typo Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
fix typo Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
fix capitalisation of heading
|
just spotted an outdated section on TravisCI thus converting to draft |
can't find what I was wondering about with that, please proceed with reviewing |
rettinghaus
approved these changes
Jan 24, 2022
|
found it rephrased it to match the current GitHub Actions CI. |
bwbohl
commented
Jan 24, 2022
musicEnfanthen
requested changes
Jan 25, 2022
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
add workflow
CONTRIBUTING.md
Outdated
|
|
||
| When a new pull request comes in, the TravisCI service will automatically build the schema using the TEIC Stylesheets, and then validate the test files and the sample encodings against the built schemas. If, for some reason, a change breaks the schema build, or breaks validation, TravisCI will report an error on the pull request. It is then up to the original contributor to fix the issue and submit the fix to the pull request. | ||
| When there is a new push to the develop branch, a GitHub Actions workflow will automatically build the MEI schema files and guidelines and publish them at: https://github.com/music-encoding/schema/tree/main/dev |
There was a problem hiding this comment.
Sorry, missed this before: Is it correct that the guidelines are published at the schema repo? Should we better mention the guidelines repo, too?
There was a problem hiding this comment.
thx for spotting missed that on :-o
add guidelines repo reference
musicEnfanthen
approved these changes
Jan 25, 2022
|
Sorry, thought that I had pushed the merge button :/ Thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** "Core Contributors"
** "Technical Team"