Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make layer cue-able #859

Merged
merged 6 commits into from
Feb 24, 2022
Merged

Make layer cue-able #859

merged 6 commits into from
Feb 24, 2022

Conversation

rettinghaus
Copy link
Member

Usually in parts a whole layer gives the cue, so it seems to make sense to make layer part of att.cue.
image
(Example taken from Behind Bars, p 572)

@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label Oct 5, 2021
Copy link
Member

@craigsapp craigsapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful feature to have. The example music demonstrates that most cues in orchestral parts are encoded in layers, with a regular-sized full-measure rests in another layer to reinforce that the cue notes are not to be played by the performer.

@rettinghaus rettinghaus added this to 2021-11-26: ODD Friday in ODD Meetings Nov 26, 2021
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds perfectly reasonable, and I'm not requesting a change to the one line added here. But. There should be some documentation about this, like we just discussed at the ODD Friday. It needs to be checked how much actual documentation we have in the Guidelines about cue'd things…

@kepper kepper moved this from 2021-11-26: ODD Friday to 2022-01-28 ODD Friday in ODD Meetings Nov 26, 2021
@musicEnfanthen
Copy link
Member

See also #668

@bwbohl bwbohl added the Type: Feature Request indicates that new features, that do not break backward compatibility, have been proposed label Jan 27, 2022
@bwbohl
Copy link
Member

bwbohl commented Jan 28, 2022

2022-01-28 ODD meeting: @rettinghaus if you could please be so kind as to add some documentation to the guidelines. Apparently there isn't anything about @cue so far, some general example might be a first start, even when limiting it to layer-cueing.

@bwbohl bwbohl moved this from 2022-01-28 ODD Friday to 2022-02-24 ODD Thursday in ODD Meetings Jan 28, 2022
@github-actions github-actions bot added Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) Component: Images changes to source/images/* (assigned automatically) labels Feb 7, 2022
@rettinghaus
Copy link
Member Author

Added a section about cue notes in the Guidelines.

@ahankinson
Copy link
Member

Probably should have one more reviewer before merging. Since @craigsapp reviewed it there have been some changes.

@musicEnfanthen
Copy link
Member

Would it be helpful to include an example of the proposed linking mechanism for cued layers with corresp in chapter 10.1.1 of the guidelines and link there from the description here?

Copy link
Member

@bwbohl bwbohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a minor comment

many thanks @rettinghaus

source/docs/04-cmn.xml Outdated Show resolved Hide resolved
@bwbohl
Copy link
Member

bwbohl commented Feb 14, 2022

@kepper could you revise your review please

<egXML xmlns="http://www.tei-c.org/ns/Examples" rend="code" xml:space="preserve" valid="true"><xi:include xmlns:xi="http://www.w3.org/2001/XInclude" href="../examples/cmn/cmn-cue_layer.txt" parse="text"/></egXML>
</figure>
</p>
<p>If the voice from which the cue notes originate is also encoded, they should refer to their sounding counterpart with the <att>corresp</att> attribute.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to include another encoding example here for this linking mechanism with corresp. This would be very helpful for users consulting this passage.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you suggested this should probably go into chapter 13 where nothing can be found about @correspat all. Opened #915.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corresp itself and all other attributes of att.linking are momentarily explained in chapter 10 (Analytical markup). If that's a good place for them, we should discuss over there in #915, right.

For the passage here, I am not asking to explain corresp in general (what would be too much out of scope of this PR), just to add a minimal encoding example how you would target the "sounding counterpart" from the cued layer. (My initial thought was to link to the corresp section from here, but since there is nothing really helpful for the use case here, it seems easier for now to include a small example here which exemplifies that usage of cued layers.) What do you think?

@musicEnfanthen musicEnfanthen changed the title make layer cue-able Make layer cue-able Feb 17, 2022
@craigsapp
Copy link
Member

Here is another example that could use this feature that I have come across:

Screen Shot 2022-02-21 at 1 34 30 PM

From Stravinsky: Perséphone (Melodrama in Three Scenes for Solo Tenor, Choir and Orchestra)

The second staff (violin 1) has two layers, with the first one being cue-sized showing the sounding pitches (also in square brackets). The performance fingerings are in the second layer.

Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@kepper kepper merged commit 6e8bde5 into music-encoding:develop Feb 24, 2022
@kepper
Copy link
Member

kepper commented Feb 24, 2022

by instruction of our technical co-chairs during ODD meeting today – many thanks ;-)

@rettinghaus rettinghaus deleted the develop-cue branch February 24, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) Component: Images changes to source/images/* (assigned automatically) Type: Feature Request indicates that new features, that do not break backward compatibility, have been proposed
Projects
No open projects
ODD Meetings
  
2022-02-24 ODD Thursday
Development

Successfully merging this pull request may close these issues.

None yet

6 participants