Make divline a valid child of layer #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Core Schema
|
Hi @yinanazhou , could you please explain a little more why you made this change, and what issue you are trying to fix? Typically we try to raise an issue about these types of changes before submitting a PR so that others know the reasons and justification for the change, and whether other options have been explored to fix your particular issue without changing the schema. Thanks! |
|
Hi @ahankinson, sorry about that! I have raised issue #861 about this PR to explain the reasons. Please let me know what you think. Thank you! |
ahankinson
approved these changes
Oct 18, 2021
bwbohl
approved these changes
Oct 18, 2021
|
Hi @bwbohl, could you please add this pull request to today's ODD meeting board? Sorry for being late! |
bwbohl
approved these changes
Oct 28, 2021
|
thanks for fixing this – it's always good to see the IG's work resulting in PRs ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the module
model.layerPart.neumestodivlineinMEI.neumes.xmlto makedivlinea valid child oflayer. We have also validate the new schema. Attached are the screenshot of the successful validation, the new schema, and the test file. Please let us know if there is a better way to do this. Thank you!
[fix_divline.zip](https://github.com/music-encoding/music-encoding/files/7305020/fix_divline.zip)