Improve anyStart schema #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix `constraint/@scheme` to schematron instead of isoschematron
* redefine `@meiversion` to be recommended
* redefine `att.basic` to include `att.meiVersion`
* add constraintSpec to assert `@meiversion`on root-element
* remove specific reference to `att.meiVersion` from `meiCorpus`
* remove specific reference to `att.meiVersion` from `meiHead`
* remove specific reference to `att.meiVersion` from `music`
* fix `constraint/@scheme` to schematron instead of isoschematron
* redefine `@meiversion` to be recommended
* redefine `att.basic` to include `att.meiVersion`
* add constraintSpec to assert `@meiversion`on root-element
* remove specific reference to `att.meiVersion` from `meiCorpus`
* remove specific reference to `att.meiVersion` from `meiHead`
* remove specific reference to `att.meiVersion` from `music`
… into ftr_anyStart
* add changeDesc
ahankinson
reviewed
Nov 11, 2021
ahankinson
requested changes
Nov 11, 2021
* improve wording Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
github-actions
bot
added
the
Component: Customizations
ahankinson
approved these changes
Nov 16, 2021
|
Two approving reviews. Merging. |
|
Thx @ahankinson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the anyStart schema by:
@meiversion(actuallyatt.meiVersion) toatt.basicand thus allowing it on any element, and consequently to prevent duplicate attributes, removing it from the elements that could have@meiversionbefore.@meiversionis present on the root element