Clarify that @oct in <note> changes between B and C #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Guidelines & Documentation
rettinghaus
approved these changes
Jan 12, 2022
bwbohl
approved these changes
Jan 12, 2022
|
thx @alastair |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main documentation for
<note>says that pname and oct conform to Acoustical Society of America representation, but didn't say that oct changes between B and C, not G-A. The tutorial at https://music-encoding.org/tutorials/101-quickstart also links to this Wikipedia page, so I added it here for more detail and added a sentence for clarification of oct.I'm not sure how to build these docs to test them - I copied the
<ref>syntax from another source file, I think it's correct.