Add quotes to customization path example #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does not hold true for macOS, I'll test it on Windows |
|
@bwbohl Okay, I was wondering why the quotes weren't there already. I tried it on Windows and only I'm checking it on my WSL now. It seems on that Ubuntu WSL 2, it works with and without quotes... |
|
ok, I can approve that it makes a differnece on my windows cmd, curiuous whether this still holds true after #888 |
bwbohl
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick thing: I realized using the
-Dcustomization.path="bla"requires quotes around the value. Maybe the build instructions are easier to follow if this is added to the example.