remove deprecated fingerprint #894
Merged
+1
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Core Schema
|
Seems to be safe to remove after thorough discussions and checks in #885 and music-encoding/metadata-ig#13. Fun fact: As far as I can see, the element was already removed in 2012 (d8b523b and 075a997) and removal confirmed in 2015 (#82). |
|
Actually, the discussion in #82 was from 2012, and just migrated over when we moved from Google Code. :-D That was on May 28, 2015, which is why it has that timestamp. |
|
Ah, I see. Thanks for the context @ahankinson ! |
bwbohl
approved these changes
Jan 27, 2022
bwbohl
added
Status: Ready To Merge
|
Thank you @rettinghaus. |
musicEnfanthen
removed
the
Status: Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the long overdue removal of
fingerprintthat is deprecated since ten years.Closes #885