Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add template for abbreveations #896

Merged

Conversation

rettinghaus
Copy link
Member

After #875 is merged this brings a special rule for the HTML version of the Guidelines to handle abbreviations correctly.

@github-actions github-actions bot added the Component: Utils changes to utils/**/* (assigned automatically) label Jan 27, 2022
@ahankinson
Copy link
Member

Could you please expand on what you mean by "handle abbreviations correctly"? What is the correct handling of abbreviations?

@rettinghaus
Copy link
Member Author

Oh yes, so right now the XSLT throws a debug message when encountering a abbr tag and converts it to a <span class="abbr"> in the HTML output. With this PR a tei:abbr gets converted into HTML's <abbr>.

@ahankinson
Copy link
Member

Great, thank you! Sounds like a good thing.

@ahankinson ahankinson requested a review from a team January 28, 2022 11:29
@rettinghaus rettinghaus added this to 2022-02-24 ODD Thursday in ODD Meetings Jan 28, 2022
@rettinghaus rettinghaus moved this from 2022-02-24 ODD Thursday to 2022-01-28 ODD Friday in ODD Meetings Jan 28, 2022
@musicEnfanthen
Copy link
Member

Thank you @rettinghaus for the addition!

@musicEnfanthen musicEnfanthen merged commit 43aaa55 into music-encoding:develop Jan 28, 2022
@rettinghaus rettinghaus deleted the develop-guidelines branch January 28, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Utils changes to utils/**/* (assigned automatically)
Projects
No open projects
ODD Meetings
  
2022-01-28 ODD Friday
Development

Successfully merging this pull request may close these issues.

None yet

3 participants