Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine MIDI names description and link #902

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Refine MIDI names description and link #902

merged 2 commits into from
Feb 24, 2022

Conversation

rettinghaus
Copy link
Member

As the allowed values for MIDI instrument names in MEI all have underscores and no parentheses they are not simply "taken from" but "based on" the official names list.
Also this updates the link.

@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label Jan 29, 2022
@rettinghaus rettinghaus mentioned this pull request Jan 29, 2022
Closed
@ahankinson
Copy link
Member

It's really too bad that we can't find a way to link to the specific page that contains the sound set listing, instead of a login page for the MIDI specification.

@rettinghaus
Copy link
Member Author

I just wanted to complain too. But I found (thanks to Wikipedia) an official page: https://www.midi.org/specifications-old/item/gm-level-1-sound-set
I'll change this.

@ahankinson
Copy link
Member

I saw that too, but was a bit put off by the "specifications-old" part of the URL. I'm not sure how long it will be maintained...

@craigsapp
Copy link
Member

They used to charge $50 for a paper copy of the specs...

@rettinghaus
Copy link
Member Author

As the URL has changed before … Still I think it is better to refer to an official page than something else.
Nowadays the specs are free, you "just" have to register.

@kepper
Copy link
Member

kepper commented Feb 1, 2022

What if we do https://web.archive.org/web/20211204235352/https://www.midi.org/specifications-old/item/gm-level-1-sound-set instead?

@rettinghaus
Copy link
Member Author

Relying on the Web Archive isn't much better in my opinion.

@ahankinson
Copy link
Member

It is what Wikipedia does to prevent stale links...

@rettinghaus rettinghaus added this to 2022-02-24 ODD Thursday in ODD Meetings Feb 20, 2022
@kepper kepper mentioned this pull request Feb 24, 2022
Open
kepper
kepper approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@kepper kepper left a comment •
edited by bwbohl

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the requested change for links to archive.org needs to be implemented for all links in the Guidelines (see #918), so this can go in like all the other links first.

@bwbohl bwbohl merged commit cc15a54 into music-encoding:develop Feb 24, 2022
@bwbohl
Copy link
Member

bwbohl commented Feb 24, 2022 •
edited

2022-02-24 ODD meeting: many thanks to everyone and bringing up the great idea in #918

@rettinghaus rettinghaus deleted the develop-midi branch February 24, 2022 15:01
@bwbohl bwbohl added this to the MEI 5.0.0 milestone May 26, 2023
@bwbohl bwbohl added the Type: Feature Request indicates that new features, that do not break backward compatibility, have been proposed label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kepper kepper kepper approved these changes

Assignees
No one assigned
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Type: Feature Request indicates that new features, that do not break backward compatibility, have been proposed
Projects
No open projects
ODD Meetings
  
2022-02-24 ODD Thursday
Milestone
MEI 5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rettinghaus @ahankinson @craigsapp @kepper @bwbohl