Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in html class #903

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

rettinghaus
Copy link
Member

This is a first step in fixing music-encoding/music-encoding.github.io#303

@musicEnfanthen
Copy link
Member

musicEnfanthen commented Jan 31, 2022

Thank you @rettinghaus for the catch! Can confirm that removal of the obviously wrong class fixes the appending of the searchmenu at the bottom.

For the alignment of the search input, can you try the following, please:

Add a class="search_input" to the following two lines in utils/guidelines_xslt/odd2html/htmlFile.xsl (find by id):

<input id="search_inputTop" title="At least 3 characters" type="text"></input>

<input name="q" id="search_input" title="At least 3 characters" type="text"></input> (probably the name="q" can be removed here as well?)

Then, in search.css replace the CSS rules under "search box" with the following:

/* search box */

.search_input {
	float: left;
	width: 200px;
	height: 1.4rem;
	background-color: #ffffff;
	border-radius: 3px;
	border: .5px solid #213b9d;
	box-sizing: border-box;
	-moz-appearance: none;
	-webkit-appearance: none;
	padding: .2rem .5rem .2rem .5rem;
	outline: 0;
	margin: 0;
}

search_button {
	position: inherit;
	height: 1.4rem;
	margin-left: -3px;
	padding: 1.5px 5px 3px 5px;
	background-color: #2440aa; 
	border: .5px solid #213b9d;
	border-radius: 0 3px 3px 0;
	box-sizing: border-box;
	cursor: pointer;
}

.search_icon {
    transform: rotate(-45deg);
    float: left;
    -moz-appearance: none;
    -webkit-appearance: none;
    box-sizing: border-box;
    box-shadow: none;
    color: #ffffff;
}

@rettinghaus
Copy link
Member Author

@musicEnfanthen Thank you. Yes, this fixes the side-bar issue.
Thanks also for the suggestion, I wanted to test it properly and save it for a second PR.

Copy link
Member

@musicEnfanthen musicEnfanthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obvious error, thanks for the catch.

@musicEnfanthen
Copy link
Member

Agreed, let's fix the search bar in a second PR.

@musicEnfanthen musicEnfanthen merged commit 6c4b1b6 into music-encoding:develop Jan 31, 2022
@rettinghaus
Copy link
Member Author

@musicEnfanthen could you please open a PR with your proposals for search_input you made earlier. I don't find the time at the moment.

@musicEnfanthen
Copy link
Member

@rettinghaus Thanks. PR prepared in #953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Utils changes to utils/**/* (assigned automatically)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants