Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect multiple remarks #904

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

rettinghaus
Copy link
Member

Multiple remarks have been concatenated without even a space. To fix this, this PR changes the XSLT to handle each paragraph in the remarks separately.

Before

image

After

image

@github-actions github-actions bot added the Component: Utils changes to utils/**/* (assigned automatically) label Jan 31, 2022
@ahankinson ahankinson added Status: Needs Review Type: Bugfix indicates that a fix for a bug has been provided labels Feb 1, 2022
@ahankinson
Copy link
Member

@music-encoding/core-contributors One more review and then merge.

@kepper kepper self-requested a review February 1, 2022 08:48
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course! – Thanks :)

@ahankinson
Copy link
Member

You can also merge, @kepper

@kepper kepper merged commit fa71b2a into music-encoding:develop Feb 1, 2022
@rettinghaus
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Utils changes to utils/**/* (assigned automatically) Type: Bugfix indicates that a fix for a bug has been provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants