-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix odd validation on constraint in mensural module #905
Conversation
@rettinghaus thank you! Could you add the scope of this PR (mensural) to its title? @martha-thomae Maybe you could have a look (or someone else from @music-encoding/ig-mensural)? |
Great! Thanks, @rettinghaus! |
Hopefully, I understand the issue correctly: I only recognized some issues concerning the customization path in this branch... just to mention it after @bwbohl fixed the windows situation lately. This hasn't anything to do with this, I was just wondering... |
you mean the changes to build.xml are not present here and you would need a rebase of this branch in order to build on your windows machine? |
@bwbohl I don't think so, your changes are there. As kind of an uneducated guess, I am not sure whether cbc7901 might have to do something with it. It broke again because of the paths. Should I make another issue for this or should I wait with testing it again when you are finished with whatever you are doing now? It might be more useful to not highjack this pr too much... |
@annplaksin That's a different issue that should have a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this PR and everything seems ok. Thanks, @rettinghaus!
I do remember that @kepper said that he was going to look into this issue and he had a draft PR, in case he wants to take a look too. But, from my side, everything seems fine and I would merge it!
many thanks everyone :) |
After some more attempts I finally was able to fix the ODD.
closes #789