Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix odd validation on constraint in mensural module #905

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

rettinghaus
Copy link
Member

After some more attempts I finally was able to fix the ODD.
closes #789

@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label Feb 1, 2022
@musicEnfanthen
Copy link
Member

@rettinghaus thank you! Could you add the scope of this PR (mensural) to its title?

@martha-thomae Maybe you could have a look (or someone else from @music-encoding/ig-mensural)?

@rettinghaus rettinghaus changed the title fix odd validation on constraint Fix odd validation on constraint in mensural module Feb 1, 2022
@martha-thomae
Copy link
Contributor

Great! Thanks, @rettinghaus!
Yes, I might be able to check this over the weekend. If anyone else from the @music-encoding/ig-mensural can see it earlier, they are welcome to do it :)

@annplaksin
Copy link
Member

Hopefully, I understand the issue correctly:
As far, it seems the validation errors in the older version are fixed. I built the schema and tested the constraints. It seems they work fine now.

I only recognized some issues concerning the customization path in this branch... just to mention it after @bwbohl fixed the windows situation lately. This hasn't anything to do with this, I was just wondering...

@bwbohl
Copy link
Member

bwbohl commented Feb 2, 2022

you mean the changes to build.xml are not present here and you would need a rebase of this branch in order to build on your windows machine?

@annplaksin
Copy link
Member

@bwbohl I don't think so, your changes are there. As kind of an uneducated guess, I am not sure whether cbc7901 might have to do something with it. It broke again because of the paths. Should I make another issue for this or should I wait with testing it again when you are finished with whatever you are doing now? It might be more useful to not highjack this pr too much...

@rettinghaus
Copy link
Member Author

@annplaksin That's a different issue that should have a separate PR.

Copy link
Contributor

@martha-thomae martha-thomae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR and everything seems ok. Thanks, @rettinghaus!

I do remember that @kepper said that he was going to look into this issue and he had a draft PR, in case he wants to take a look too. But, from my side, everything seems fine and I would merge it!

@rettinghaus rettinghaus added this to 2022-02-24 ODD Thursday in ODD Meetings Feb 20, 2022
@kepper kepper merged commit ce8ec8d into music-encoding:develop Feb 24, 2022
@kepper
Copy link
Member

kepper commented Feb 24, 2022

many thanks everyone :)

@rettinghaus rettinghaus deleted the develop-constraint branch February 24, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Schema changes to source/modules/* (assigned automatically)
Projects
No open projects
ODD Meetings
  
2022-02-24 ODD Thursday
Development

Successfully merging this pull request may close these issues.

Validation error in MEI.mensural.xml
6 participants