Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct typographic symbols in guidelines #910

Merged
merged 6 commits into from
Feb 24, 2022

Conversation

rettinghaus
Copy link
Member

This PR replaces typewriter apostrophes and quotation marks with the correct typographic ones and unifies all occurrences.

@github-actions github-actions bot added the Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) label Feb 7, 2022
@craigsapp
Copy link
Member

The apostrophes are fixed but single-quotation endings are made worse:

Screen Shot 2022-02-07 at 8 09 13 AM

(Starting quotes are being used for ending quotes).

@craigsapp
Copy link
Member

craigsapp commented Feb 7, 2022

Never mind: zooming in on them, I can now see that they are different... I searched for one, but the web browser also matches to the other.

Copy link
Member

@bwbohl bwbohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally I like the idea of pimping up typography in the guidelines. In some casese I wonder though, whether it would be better to come up with a stronger typed markup, e.g. for attribute values that could be markedUp using <tei:val>

source/docs/03-metadata.xml Outdated Show resolved Hide resolved
source/docs/05-mensural.xml Outdated Show resolved Hide resolved
source/docs/05-mensural.xml Show resolved Hide resolved
source/docs/04-cmn.xml Outdated Show resolved Hide resolved
source/docs/04-cmn.xml Outdated Show resolved Hide resolved
source/docs/04-cmn.xml Show resolved Hide resolved
source/docs/04-cmn.xml Outdated Show resolved Hide resolved
@rettinghaus
Copy link
Member Author

@bwbohl I like the idea using val but that should probably go with another PR. We need to add a matching rule to the css.

@musicEnfanthen musicEnfanthen changed the title use correct typographic symbols Use correct typographic symbols in guidelines Feb 17, 2022
@doerners doerners added this to 2022-02-24 ODD Thursday in ODD Meetings Feb 22, 2022
@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label Feb 24, 2022
@kepper kepper merged commit a2a781e into music-encoding:develop Feb 24, 2022
@kepper
Copy link
Member

kepper commented Feb 24, 2022

as per consensus at ODD meeting Feb 2022. Many thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically)
Projects
No open projects
ODD Meetings
  
2022-02-24 ODD Thursday
Development

Successfully merging this pull request may close these issues.

None yet

4 participants