Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description for MEI virtual unit #916

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

doerners
Copy link
Contributor

This PR adds a description of the nature of MEI virtual unit to chapter 3 of the Guidelines.
Closes #782

@github-actions github-actions bot added Component: Core Schema changes to source/modules/* (assigned automatically) Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) labels Feb 22, 2022
Copy link
Member

@rettinghaus rettinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@rettinghaus rettinghaus added this to 2022-02-24 ODD Thursday in ODD Meetings Feb 23, 2022
@musicEnfanthen
Copy link
Member

Thank you @doerners .

Please note that there is also

<attDef ident="vu.height" usage="opt">
<desc>Defines the height of a "virtual unit" (vu) in terms of real-world units. A single vu
is half the distance between the vertical center point of a staff line and that of an
adjacent staff line.</desc>

Maybe it's possible to harmonize the wording in all three passages to avoid diverging interpretations?

@bwbohl
Copy link
Member

bwbohl commented Feb 24, 2022

In terms of harmonisation I'd prefer the "middle" of the staffline, because then page orientation is not of importance.
If you would be so kind as to harmonise it in the other spots (visual and shared)

@musicEnfanthen musicEnfanthen self-assigned this Feb 24, 2022
@bwbohl
Copy link
Member

bwbohl commented Feb 24, 2022

2022-02-24 ODD meeting: As soon as it's done and reviewed we can merge it.

@musicEnfanthen musicEnfanthen moved this from 2022-02-24 ODD Thursday to 2022-03-25 ODD Friday in ODD Meetings Feb 24, 2022
Copy link
Member

@musicEnfanthen musicEnfanthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you @doerners

@musicEnfanthen musicEnfanthen merged commit 9580967 into music-encoding:develop Feb 25, 2022
@musicEnfanthen musicEnfanthen moved this from 2022-03-25 ODD Friday to 2022-02-24 ODD Thursday in ODD Meetings Feb 25, 2022
@doerners doerners deleted the develop-vu branch October 20, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically)
Projects
No open projects
ODD Meetings
  
2022-02-24 ODD Thursday
Development

Successfully merging this pull request may close these issues.

Add explanation of virtual units to Guidelines
4 participants