restrict constraint on clef lines #921
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Core Schema
rettinghaus
moved this from 2022-04-28 ODD Thursday
to 2022-03-25 ODD Friday
in ODD Meetings
musicEnfanthen
requested review from
musicEnfanthen
and removed request for
musicEnfanthen
annplaksin
approved these changes
Mar 25, 2022
|
@bwbohl This is ready to be merged. Please feel free to add your second review and merge as time permits. |
musicEnfanthen
added
Status: Ready To Merge
bwbohl
approved these changes
Mar 31, 2022
|
thx for your work @rettinghaus and thanks for the review @musicEnfanthen |
musicEnfanthen
removed
the
Status: Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the constraint inline with another one (line 596). As correctly stated there, percussion and tabular clef don't need a
linespecified, yet<clef shape="perc" />or<clef shape="TAB" />were marked as an error.