-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data.MIDINAMES #927
Fix data.MIDINAMES #927
Conversation
Is there a reason it's now starting at 1, not 0? MIDI program changes are 0-indexed, so this should probably be reflected in MEI. See: https://www.recordingblogs.com/wiki/midi-program-change-message |
This reflects the MIDI Program Change given in the original specifications. Otherwise we need to change the given Keys for percussions accordingly. The remarks state:
If that leads to confusion we should drop this, because the description in |
About this particular change: The original says Given that we're specifically trying to fix an issue with it rendering to RNG correctly, and not actually trying to change the MIDI semantics, I would suggest keeping the original wording and not introducing this change here. |
@rettinghaus thanks for the PR, and thanks for the approval @ahankinson. Will take this PR to the next ODD meeting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. Looks good.
thanks! |
This resolves the problematic
altIdent
indata.MIDINAMES
and fixes a wrong value in this range, as Bag pipe should become "Bag_pipe" instead of "Bagpipe".This is also a bugfix for MEI 4.
closes #812