Add and handle val tags #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musicEnfanthen
moved this from 2022-03-25 ODD Friday
to 2022-04-28 ODD Thursday
in ODD Meetings
|
@rettinghaus could you please resolve conflicts and then ping me for review? |
github-actions
bot
added
Component: Core Schema
|
@bwbohl merge conflicts have been resolved. |
bwbohl
previously approved these changes
Apr 22, 2022
musicEnfanthen
requested changes
May 2, 2022
|
Thank you @rettinghaus. Please find some comments and open questions above. |
github-actions
bot
removed
the
Component: Utils
musicEnfanthen
previously approved these changes
May 5, 2022
|
Thank you @rettinghaus for addressing the comments. Looks good to me. |
musicEnfanthen
approved these changes
May 24, 2022
musicEnfanthen
moved this from 2022-04-28 ODD Thursday
to 2022-05-27 ODD Friday
in ODD Meetings
|
ODD meeting, May 25, 2022: Thank you @rettinghaus . @kepper will have a final look and check about consequences for the XLST workflows. |
musicEnfanthen
moved this from 2022-05-27 ODD Friday
to 2022-06-30 ODD Thursday
in ODD Meetings
|
Ping @kepper. Would you be able to have a look until the next ODD meeting? |
musicEnfanthen
moved this from 2022-06-30 ODD Thursday
to 2022-07-29 ODD Friday
in ODD Meetings
bwbohl
approved these changes
Jul 28, 2022
|
Merged at ODD meeting (July 2022). @kepper If you think that there is some change needed afterwards, please let us know. |
|
Thank you @rettinghaus for the improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address one part of #913 by unifying the handling of attribute values in the Guidelines.
Before values were treated very differently in different locations, sometimes they were in italics, sometimes in single or double quotes, sometimes in plain text. I tried to find every occurrence, wrap it into
tei:valtags and added a corresponding css rule, so that every value should be shown in single quotes (as it is done in the TEI Guidelines). Furthermore I created a newguidelines.cssto collect specific rules there.Additionally this brings some typographically correct possessive apostrophes.