Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tei.css #939

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Update tei.css #939

merged 2 commits into from
Apr 28, 2022

Conversation

rettinghaus
Copy link
Member

This updates the used tei.css to the version from the latest release.
As far as I can see this is basically a clean-up and reorder thing, so this shouldn't hurt. But in any case @kepper should give it a test run.

@musicEnfanthen musicEnfanthen added this to 2022-04-28 ODD Thursday in ODD Meetings Mar 25, 2022
@bwbohl
Copy link
Member

bwbohl commented Apr 22, 2022

@kepper any chance of reviewing this before next ODD meeting?

@kepper
Copy link
Member

kepper commented Apr 22, 2022

I'll see what I can do…

Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running it locally seems fine – at least I couldn't find any substantial differences within a reasonable testing time. We do have some font issues, but they are unrelated to this, so I will try to address them separately… Many thanks for updating this, @rettinghaus 👍

@ahankinson ahankinson added Status: Ready To Merge indicates that a pull request is ready for merging and removed Status: Needs Review labels Apr 26, 2022
@ahankinson
Copy link
Member

Looks good to me. Will wait for one of the co-chairs to merge at the ODD meeting unless I hear otherwise.

@ahankinson ahankinson merged commit 98da70d into music-encoding:develop Apr 28, 2022
@rettinghaus rettinghaus deleted the develop-tei branch April 29, 2022 07:49
@musicEnfanthen musicEnfanthen removed the Status: Ready To Merge indicates that a pull request is ready for merging label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
ODD Meetings
  
2022-04-28 ODD Thursday
Development

Successfully merging this pull request may close these issues.

None yet

5 participants