Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build clean up #962

Merged

Conversation

musicEnfanthen
Copy link
Member

@musicEnfanthen musicEnfanthen commented May 18, 2022

As a further preparation for #959, this PR provides some housekeeping for the build process (mainly for the ant script in build.xml), including:

  • typo fixes
  • improved grouping and naming of variables (not perfect, but maybe more consistent)
  • addition of variables for lib files (saxon, xerces) to reduce the need to update versions in multiple places

Tested locally, "ant dist" (running and building everything) still works as before.

@github-actions github-actions bot added Component: Build changes to build.xml (assigned automatically) Component: Utils changes to utils/**/* (assigned automatically) labels May 18, 2022
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good to me – thanks! 👍

@bwbohl bwbohl merged commit 728010e into music-encoding:pdf-guidelines May 18, 2022
@musicEnfanthen musicEnfanthen deleted the guidelines-clean-up branch May 19, 2022 06:56
@musicEnfanthen
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build changes to build.xml (assigned automatically) Component: Utils changes to utils/**/* (assigned automatically)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants