Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop style #976

Merged
merged 4 commits into from
Oct 1, 2022
Merged

Conversation

rettinghaus
Copy link
Member

This PR is an attempt to bring the style of the source files a bit more in line with TEI.

  • extracts resolved abbreviations into gloss elements with an additional versionDate attribute
  • adds xml:lang attributes to desc, gloss, and remarks

Further adjustments to the XSLTs are needed.

@rettinghaus rettinghaus marked this pull request as draft June 15, 2022 13:38
@github-actions github-actions bot added Component: Core Schema changes to source/modules/* (assigned automatically) Component: Utils changes to utils/**/* (assigned automatically) labels Jun 15, 2022
@ahankinson
Copy link
Member

@rettinghaus are you still working on this issue?

@rettinghaus
Copy link
Member Author

Thanks for the reminder! Obviously I need to resolve those conflicts. And I'd like to have some feedback on the changes in the XSLTs from @kepper.
Or we split things into multiple PRs and keep this just for the changes in the sources.

@rettinghaus
Copy link
Member Author

Conflicts resolved.

@rettinghaus rettinghaus marked this pull request as ready for review September 22, 2022 14:30
@musicEnfanthen musicEnfanthen added this to the Guidelines milestone Sep 22, 2022
@bwbohl bwbohl requested a review from kepper September 27, 2022 14:57
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed during MEI dev meeting Berlin 2022, approved by Ich, Klaus, Stefan, Perry, jo

@musicEnfanthen musicEnfanthen merged commit e3cecc0 into music-encoding:develop Oct 1, 2022
@rettinghaus rettinghaus deleted the develop-lang branch October 1, 2022 13:00
@musicEnfanthen
Copy link
Member

Thanks everyone! Merged at MEI Developer Workshop 2022 in Berlin

@ahankinson
Copy link
Member

ahankinson commented Oct 1, 2022

Sorry, I had a question about this one: Given that xml:lang applies to all elements and their children, is it enough to just set it once on all the elements on the root element, and then only add/change it for those paragraphs where it is not in English?

https://www.oxygenxml.com/dita/1.3/specs/archSpec/base/xmllang.html

"The @xml:lang attribute applies to all attributes and content of the element where it is specified, unless it is overridden with @xml:lang on another element within that content."

@rettinghaus
Copy link
Member Author

Well you could do that, but then it applies also to every specified element name and attribute value. But values like "adlib" and "sprech" are not English. Do we want to specify the language of every value? Also I think that it is not possible to 'reset' the language.

@ahankinson
Copy link
Member

But not every term within the paragraphs are English either -- It's music; half the terms are probably Italian! 😄 I think the main point is that the guidelines are written in English.

It is possible to "reset":

<?xml version="1.0" encoding="utf-8" ?>
<doc xml:lang="en">
 <list title="Titre en français" xml:lang="fr">
  <p>Texte en français.</p>
  <p xml:lang="fr-ca">Texte en québécquois.</p>
  <p xml:lang="en">Second text in English.</p>
 </list>
 <p>Text in English.</p>
</doc>

From: https://www.opentag.com/xfaq_lang.htm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Component: Utils changes to utils/**/* (assigned automatically)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants