Add ordering information to lines.color #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Core Schema
ahankinson
reviewed
Jun 15, 2022
|
+1
--
p.
From: Andrew Hankinson ***@***.***>
Sent: Wednesday, June 15, 2022 12:51 PM
To: music-encoding/music-encoding ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [music-encoding/music-encoding] Add ordering information to lines.color (PR #977)
@ahankinson commented on this pull request.
________________________________
In source/modules/MEI.visual.xml<#977 (comment)>:
<datatype maxOccurs="unbounded">
<rng:ref name="data.COLOR"/>
</datatype>
+ <remarks>
+ <p>The value is structured; that is, it should contain a single color value or have
+ the same number of space-separated values as the number of lines indicated by the
+ lines attribute. The first value then applies to the lowest line of the staff.
+ A line can be made invisible by assigning it the same color as the
I think we should strike this last sentence since data.COLOR allows alpha-channel colours, so it is possible to make a fully transparent ("invisible") line with the values in this attribute.
—
Reply to this email directly, view it on GitHub<#977 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABLSX3LJGREUJWEP2M3DXR3VPICYRANCNFSM5Y3WE3DQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.******@***.***>>
|
musicEnfanthen
requested changes
Jun 30, 2022
musicEnfanthen
moved this from 2022-06-30 ODD Thursday
to 2022-07-29 ODD Friday
in ODD Meetings
musicEnfanthen
approved these changes
Jun 30, 2022
|
Thanks @rettinghaus |
|
@ahankinson Are the recent changes OK with you? |
ahankinson
approved these changes
Jun 30, 2022
rettinghaus
added
the
Status: Ready To Merge
bwbohl
approved these changes
Jul 7, 2022
|
Three approvals. Merging right now. |
musicEnfanthen
removed
the
Status: Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to be a bit more explicit about the possible values in
@lines.color.Closes #946