Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @meiversion for MEI basic #984

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Update @meiversion for MEI basic #984

merged 2 commits into from
Jul 15, 2022

Conversation

lpugin
Copy link
Member

@lpugin lpugin commented Jul 15, 2022

Because this will now be a version 5.0 release, the version attribute needed to be updated accordingly.

Because this will now be a version 5.0 release, the version attribute needed to be updated accordingly.
@github-actions github-actions bot added the Component: Customizations changes to customizations/**/* (assigned automatically) label Jul 15, 2022
rettinghaus
rettinghaus previously approved these changes Jul 15, 2022
@lpugin lpugin requested a review from ahankinson July 15, 2022 10:56
ahankinson
ahankinson previously approved these changes Jul 15, 2022
Copy link
Member

@musicEnfanthen musicEnfanthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lpugin. I am fine with it, too.

Just wondering if resp. want to make sure that the "Release Candidate" status is still valid/needed? Can someone clarify this question?

@lpugin
Copy link
Member Author

lpugin commented Jul 15, 2022

I was wondering too. Having 5.0.0-dev+basic would be better in my opinion too. I'll change to that.

We have no release candidate concept in MEI workflow, do `-dev` in more inline with what we do with the schema.
@lpugin lpugin dismissed stale reviews from ahankinson and rettinghaus via 5e9790f July 15, 2022 12:21
@lpugin lpugin removed the request for review from kepper July 15, 2022 12:23
@musicEnfanthen musicEnfanthen merged commit 6095a34 into develop Jul 15, 2022
@lpugin lpugin deleted the lpugin-patch-1 branch July 15, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customizations changes to customizations/**/* (assigned automatically)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants