Fix/934 #992
Merged
Fix/934 #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `<exhibHist>`, `<treatHist>` and `<treatSched>` have been remodelled after `<provenance>` in music-encoding#911, the corresponding Schematron rule to report an error in work and expression contexts had to be updated. Moreover, in music-encoding#934, we agreed also to apply this rule to the manifestation context if the manifestation is not a singleton. This commit applies the necessary changes.
github-actions
bot
added
the
Component: Core Schema
bwbohl
added
Status: Needs Review
Type: Bugfix
rettinghaus
previously approved these changes
Sep 22, 2022
doerners
suggested changes
Sep 23, 2022
There was a problem hiding this comment.
The schematron rule looks find to me, thanks @bwbohl! However, I noticed two things I think should be changed within the description:
- Not all elements affected by the schematron rule are listed within the description. I think it would be good to list all of them.
- My impression was that expression and manifestation were mixed up in the second half of the description – if I'm not totally mistaken there is no singleton expression.
The wording I provided is just a suggestion and I'm not set that it has to stay like this :)
Co-authored-by: Sophia Dörner <38356908+doerners@users.noreply.github.com>
github-actions
bot
added
the
Component: Core Schema
|
thanks for the valuable contribution @doerners ! Merged it, If you would be so kind as to update your review ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
<exhibHist>,<treatHist>and<treatSched>have been remodelled after<provenance>in #911, the corresponding Schematron rule to report an error in work and expression contexts had to be updated. Moreover, in #934, we agreed also to apply this rule to the manifestation context if the manifestation is not a singleton.This PR applies the necessary changes.