Refresh the JSON specs #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… after On my system (yaml gem version 0.1.0), `foo.merge(bar)` will include the keys of `foo` before the keys of `bar`, so the previous Rakebuild definition would include the ATTN warning *after* the test data in the rendered JSON files.
|
I now realize that this PR overlaps with #90 from August 2015 which is doing the same thing. This should have been fixed long ago. |
|
Any reason not to merge this? |
|
I would be in favor of merging, indeed! I don't think it is necessary, but before merging you could maybe try to see if you can reproduce the warning-placement issue on your system: if you run the command to refresh the specs ( |
|
Confirming the warning-placement issue, thanks for fixing. Agree, should have been merged a long time ago. |
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
rake buildto render JSON specs properly (otherwise the ATTN warning would be at the end of each test, instead of at the begining as in their current versioned form.)rake buildthat refreshes .json files that are stale compared to the .yml reference.