Update to Go 1.8 features #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've changed the deploy condition a bit to be closer to what the Travis documentation recommends: https://docs.travis-ci.com/user/languages/go#Environment-Variable AppVeyor should always be on the latest Go release without having to change configurations.
We haven't actually made any changes that require Go 1.8 yet, but this branch will be full of them. In general, we'll only support the latest version since there's really no difficulty in using the latest. Yes, it will mean dropping support for some older platforms, but these don't seem to be well-supported in older Go versions anyway. I'm not a huge fan of our build constraint mechanism here, because it doesn't really provide any feedback as to why Mutagen is failing to build, and it relies on code trying to pull in Mutagen version information, but there's not really any other way to approach this.
This isn't strictly necessary and almost certainly won't boost performance, but it does clean up the code a bit.
We should also look into aligning the CI steps at some point, but they aren't exactly 1-to-1 between Travis and AppVeyor.
This commit also removes some old comments about MIPS uname values, because I'm fairly certain they're correct at this point and if not then someone can complain about it and then I'll have a MIPS tester.
This wouldn't gain us anything but would require an additional allocation for each encoding, so it's not worth it. Strict checking might also just be slower.
Now that we're using Go 1.8, filepath.Abs will automatically call filepath.Clean on its result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.8 brings a lot of goodies that are worth using. Ideally, I'd like to take advantage of the following:
This is currently blocked by Go 1.8 appveyor/ci#1330. We could use Chocolatey to update, but 32-bit support is hard in that case, and AppVeyor usually gets these updates out quickly anyway.AppVeyor has updated to Go 1.8.sort.Slicefilesystem.Normalizeto take advantage of Go 1.8 behaviorSwitch to usingActually, it turns out that theos.Executableinstead ofkardianos/osext.os.Executableimplementation on OpenBSD usesprocfsto determine the executable path. This is somewhat more technically correct, but OpenBSD killed support forprocfs, so this doesn't really work. Thekardianos/osextpackage attempts to find the process usingargv[0], which is sufficient for our purposes despite being imperfect. Although in newer versions, it just falls back toos.Executableif available, so we'll have to be careful not to use it.