Global shortcuts search #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it simplier.
So the workflow structure looks organized.
mutdmour
reviewed
Jul 21, 2018
| addShortcuts(app, action) | ||
| if addShortcuts(app, action) == 0: | ||
| wf.add_item(nothing_found_error_text, icon=ICON_WARNING) | ||
| elif (u'--search-global' in args): |
There was a problem hiding this comment.
seems to be working well. My main issue with this right now is that it's not accounting for hidden/only_shown apps. it would create an asymmetrical experience. and global search seems like where it's most needed.
though it's technically global, so it might make sense to keep it inclusive of all apps, or else make it configurable.
in settings.json, have:
include_all_app_global_search: True
excluding hidden apps being the default behavior.
For now, I am going to merge it and create an issue for this.
mutdmour
approved these changes
Jul 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #5.
For the global search I created a separate script filter with
cheatsheetgkeyword.