test: add a test for readrows tags for fix googleapis#1477

mutianf · Nov 5, 2022 · ee5ea42 · ee5ea42
1 parent 6db9326
commit ee5ea42
Showing 1 changed file with 24 additions and 1 deletion.
diff --git a/...rc/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java b/...rc/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java
@@ -324,7 +324,7 @@ public void testRetryCount() {
   }
 
   @Test
-  public void testMutateRowAttempts() {
+  public void testMutateRowAttemptsTagValues() {
     when(mockFactory.newTracer(any(), any(), any()))
         .thenReturn(
             new BuiltinMetricsTracer(
@@ -345,6 +345,29 @@ public void testMutateRowAttempts() {
     assertThat(status.getAllValues()).containsExactly("UNAVAILABLE", "UNAVAILABLE", "OK");
   }
 
+  @Test
+  public void testReadRowsAttemptsTagValues() {
+    when(mockFactory.newTracer(any(), any(), any()))
+        .thenReturn(
+            new BuiltinMetricsTracer(
+                OperationType.ServerStreaming,
+                SpanName.of("Bigtable", "ReadRows"),
+                statsRecorderWrapper));
+
+    Lists.newArrayList(stub.readRowsCallable().call(Query.create("fake-table")).iterator());
+
+    // Set a timeout to reduce flakiness of this test. BasicRetryingFuture will set
+    // attempt succeeded and set the response which will call complete() in AbstractFuture which
+    // calls releaseWaiters(). onOperationComplete() is called in TracerFinisher which will be
+    // called after the mutateRow call is returned. So there's a race between when the call returns
+    // and when the record() is called in onOperationCompletion().
+    verify(statsRecorderWrapper, timeout(50).times(fakeService.getAttemptCounter().get()))
+        .recordAttempt(status.capture(), tableId.capture(), zone.capture(), cluster.capture());
+    assertThat(zone.getAllValues()).containsExactly("global", ZONE);
+    assertThat(cluster.getAllValues()).containsExactly("unspecified", CLUSTER);
+    assertThat(status.getAllValues()).containsExactly("UNAVAILABLE", "OK");
+  }
+
   private static class FakeService extends BigtableGrpc.BigtableImplBase {
 
     static List<ReadRowsResponse> createFakeResponse() {