Fix code quality issues #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes - Remove unused imports - Use `_` for unused variables - Remove unnecessary list comprehension - Add .deepsource.toml file to run continuous static analysis on the repository with DeepSource
b-price
pushed a commit
to b-price/mojomutpy
that referenced
this pull request
Mar 14, 2024
* adding requirements into `setup.py` adding pylint and pytest commands in `setup.py` * adding `.pylintrc` * removing requirements files and tox * allowing travis to test over all "supported" versions of python * fixing warning with specifying `pytest` * cleaning up tests to work better over all versions of python disabling checking python3.6+ syntaxt on lower versions * possible var misspelling fix? * adding pylint disables * fixing python2.7 import issues for `zip_longest` * adding testing for python3.3 * Revert "adding testing for python3.3" This reverts commit ee204193 * ignoring `line-too-long` pylint warning * Revert: removing requirements files and tox adding back requirements files removing the recursive flag * adding back usage of requirement files in `setup.py` * removing `pylint` components * removing cloning of `pypy` * disabling testing of python3.5 3.4 * fixing tests * removing pylint ignores * fixing shebangs * removing `pylint` as a test requirement * adding trailing newline * removing commented out environment tests * removing module docstring * removing unneeded shebangs * removing unneeded import * removing unneeded encoding hints * Adding back `tox` * testing on both py27 and py36 * improved coverage report generation * flake8 linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
_for unused variablesThis PR also adds
.deepsource.tomlconfiguration file to run static analysis continuously on the repo with DeepSource. Upon enabling DeepSource, quality and security analysis will be run on every PR to detect 500+ types of problems in the changes — including bug risks, anti-patterns, security vulnerabilities, etc.DeepSource is free to use for open-source projects, and is used by teams at NASA, Uber, Slack among many others, and open-source projects like ThoughtWorks/Gauge, Masonite Framework, etc.
To enable DeepSource analysis after merging this PR, please follow these steps: