Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Game Rotation Vector sensor Implementation #20

Merged
merged 4 commits into from
Apr 3, 2023
Merged

feat: Game Rotation Vector sensor Implementation #20

merged 4 commits into from
Apr 3, 2023

Conversation

aditya-bhawsar-mm
Copy link
Member

@aditya-bhawsar-mm aditya-bhawsar-mm commented Mar 30, 2023 •
edited

This PR adds support for the game rotation vector sensor

README is also updated to include the abovesaid implementation's composable
(rememberGameRotationVectorSensorState())

game_vector

@aditya-bhawsar-mm aditya-bhawsar-mm self-assigned this Mar 30, 2023
@aditya-bhawsar-mm aditya-bhawsar-mm added the enhancement New feature or request label Mar 31, 2023
@aditya-bhawsar-mm aditya-bhawsar-mm marked this pull request as ready for review March 31, 2023 04:11
@aditya-bhawsar-mm aditya-bhawsar-mm linked an issue Mar 31, 2023 that may be closed by this pull request
Required support for Game Rotation Vector Sensor #23
Closed
shubhamsinghmutualmobile
shubhamsinghmutualmobile approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@shubhamsinghmutualmobile shubhamsinghmutualmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ Thank you for your contributions! 🚀

@aditya-bhawsar-mm aditya-bhawsar-mm merged commit 9fdcab5 into development Apr 3, 2023
@shubhamsinghmutualmobile shubhamsinghmutualmobile deleted the ab_game_rotation_vector_support branch April 3, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsinghmutualmobile shubhamsinghmutualmobile shubhamsinghmutualmobile approved these changes

Assignees

@aditya-bhawsar-mm aditya-bhawsar-mm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required support for Game Rotation Vector Sensor
2 participants
@aditya-bhawsar-mm @shubhamsinghmutualmobile